Fix the nodes' owners not being updated when display: contents is used
#1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
Shared with Meta
|
I’m away until next week, but could look closer then. @joevilches @rozele could you take a look in the meantime? |
|
@zeyap has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
zeyap
pushed a commit
to zeyap/react-native
that referenced
this pull request
Nov 19, 2024
Summary: In facebook/yoga#1729 I moved the cleanup of `display: contents` nodes to happen before all the early returns, but that change also made it be called **before** `cloneChildrenIfNeeded`. It actually needs to be called after `cloneChildrenIfNeeded` to make sure that children of `display: contents` nodes are properly owned. It also needs to be called in every short-path, so it's being called in four places in this PR. Please let me know whether it's ok or not. X-link: facebook/yoga#1743 Reviewed By: NickGerleman Differential Revision: D65953902 Pulled By: zeyap
zeyap
pushed a commit
to zeyap/react-native
that referenced
this pull request
Nov 20, 2024
…sed (facebook#47733) Summary: In facebook/yoga#1729 I moved the cleanup of `display: contents` nodes to happen before all the early returns, but that change also made it be called **before** `cloneChildrenIfNeeded`. It actually needs to be called after `cloneChildrenIfNeeded` to make sure that children of `display: contents` nodes are properly owned. It also needs to be called in every short-path, so it's being called in four places in this PR. Please let me know whether it's ok or not. X-link: facebook/yoga#1743 Reviewed By: NickGerleman Differential Revision: D65953902 Pulled By: zeyap
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 21, 2024
Summary: X-link: facebook/react-native#47733 In facebook/yoga#1729 I moved the cleanup of `display: contents` nodes to happen before all the early returns, but that change also made it be called **before** `cloneChildrenIfNeeded`. It actually needs to be called after `cloneChildrenIfNeeded` to make sure that children of `display: contents` nodes are properly owned. It also needs to be called in every short-path, so it's being called in four places in this PR. Please let me know whether it's ok or not. X-link: facebook/yoga#1743 Reviewed By: NickGerleman Differential Revision: D65953902 Pulled By: zeyap fbshipit-source-id: 0b18a5651f19c23564f5b3aa2a50833426e9ca5f
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 21, 2024
…sed (#47733) Summary: Pull Request resolved: #47733 In facebook/yoga#1729 I moved the cleanup of `display: contents` nodes to happen before all the early returns, but that change also made it be called **before** `cloneChildrenIfNeeded`. It actually needs to be called after `cloneChildrenIfNeeded` to make sure that children of `display: contents` nodes are properly owned. It also needs to be called in every short-path, so it's being called in four places in this PR. Please let me know whether it's ok or not. X-link: facebook/yoga#1743 Reviewed By: NickGerleman Differential Revision: D65953902 Pulled By: zeyap fbshipit-source-id: 0b18a5651f19c23564f5b3aa2a50833426e9ca5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1729 I moved the cleanup of
display: contentsnodes to happen before all the early returns, but that change also made it be called beforecloneChildrenIfNeeded. It actually needs to be called aftercloneChildrenIfNeededto make sure that children ofdisplay: contentsnodes are properly owned.It also needs to be called in every short-path, so it's being called in four places in this PR. Please let me know whether it's ok or not.