Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio issues #1639

Closed
Absotively opened this issue Jun 6, 2019 · 1 comment
Closed

Visual Studio issues #1639

Absotively opened this issue Jun 6, 2019 · 1 comment

Comments

@Absotively
Copy link
Contributor

The Visual Studio 2010 projects for libzstd and libstd-dll have the setting to produce assembler listings turned on. At least in Visual Studio 2017, this usually causes linking to a copy of libzstd that was built on another machine to fail, because the existence of assembler listings somehow causes the linker to look for things by an absolute path that's stored when libzstd is built. It doesn't seem likely that most users are looking for assembler listings, and the other Visual Studio 2010 projects don't produce them, so I'd like to suggest they be turned off.

Also, the Visual Studio project for libzstd defines "ZSTD_DLL_EXPORT=1", which causes executables that use the static library to export the zstd api functions. This define should probably be removed from this project.

I can submit a pull request with these settings changes if that's helpful.

@Cyan4973
Copy link
Contributor

Cyan4973 commented Jun 6, 2019

sure !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants