Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fuzzer] Fuzz frame info functions #1590

Merged
merged 5 commits into from
Apr 17, 2019
Merged

[fuzzer] Fuzz frame info functions #1590

merged 5 commits into from
Apr 17, 2019

Conversation

terrelln
Copy link
Contributor

  • Write a fuzzer that fuzzes all the helper functions that take compressed input.
  • Found an out-of-bounds read in ZSTD_decompressBound().
  • Fix a bug where ZSTD_findDecompressedSize() would return a zstd error code if readSkippableFrameSize() failed.

@terrelln
[libzstd] Fix ZSTD_decompressBound() on bad skippable frames
450feb0 
The function didn't verify that the skippable frame size is correct.
@terrelln
[fuzzer] Add a fuzzer for frame info functions
09caa4d 
Add a fuzzer that fuzzes all helper functions that take compressed
input. This fuzzer caught one out of bounds read in
`ZSTD_decompressBound()`.
@terrelln
[legacy] Return the right error code
5922f4e
@terrelln
[libzstd] Check the size in readSkippableFrameSize()
ee130a9
@terrelln terrelln merged commit af3531e into facebook:dev Apr 17, 2019
@felixhandte felixhandte mentioned this pull request Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrelln @Cyan4973 @facebook-github-bot