-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure the source files #1679
Conversation
This is great! |
The change itself looks good to me. Now, the main issue is around build scripts. This includes :
For the PR to pass, all build systems must be updated. At this stage, a quickfix is good enough. |
@Cyan4973 Thanks for the comment! I was confused about what was causing the issue. Let me look into them. |
30ee89a
to
41e39c8
Compare
This pull request had one failure on Travis CI on (Trusty (gcc-8 + ASan + UBSan + Fuzz Test)). The cause of the failure is independent from this pull request. It's caused because gcc8 is not properly suppressing signed-integer-overflow (pointer-overflow) for ubsan. I have created an issue for it (#1686). |
file(GLOB CompressSources ${LIBRARY_DIR}/compress/*.c) | ||
file(GLOB DecompressSources ${LIBRARY_DIR}/decompress/*.c) | ||
file(GLOB DictBuilderSources ${LIBRARY_DIR}/dictBuilder/*.c) | ||
file(GLOB DeprecatedSources ${LIBRARY_DIR}/deprecated/*.c) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ephiepark , this new GLOB
is much better for file layout flexibility
Thanks @ephiepark , As we are close to a new release, we'll wait a bit for the "freeze" snapshot, and merge this patch right after that. |
Release completed, |
This pull request reorganizes codes into different files.
This changes have the following side effect: