-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Clearing Tables Even When Changing CParams #1780
Merged
felixhandte
merged 21 commits into
facebook:dev
from
felixhandte:workspace-efficiency-3
Sep 16, 2019
Merged
Avoid Clearing Tables Even When Changing CParams #1780
felixhandte
merged 21 commits into
facebook:dev
from
felixhandte:workspace-efficiency-3
Sep 16, 2019
Commits on Sep 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 17b6da2 - Browse repository at this point
Copy the full SHA 17b6da2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14c5471 - Browse repository at this point
Copy the full SHA 14c5471View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0492b9a - Browse repository at this point
Copy the full SHA 0492b9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b10bb5 - Browse repository at this point
Copy the full SHA 5b10bb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad16eda - Browse repository at this point
Copy the full SHA ad16edaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b28e80 - Browse repository at this point
Copy the full SHA 1b28e80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9968a53 - Browse repository at this point
Copy the full SHA 9968a53View commit details -
Configuration menu - View commit details
-
Copy full SHA for f31ef28 - Browse repository at this point
Copy the full SHA f31ef28View commit details -
Configuration menu - View commit details
-
Copy full SHA for edb3ad0 - Browse repository at this point
Copy the full SHA edb3ad0View commit details
Commits on Sep 11, 2019
-
Shrink Clean Table Area When Copying Table Contents into Context
The source matchState is potentially at a lower current index, which means that any extra table space not overwritten by the copy may now contain invalid indices. The simple solution is to unconditionally shrink the valid table area to just the area overwritten.
Configuration menu - View commit details
-
Copy full SHA for 13e29a5 - Browse repository at this point
Copy the full SHA 13e29a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1999b2e - Browse repository at this point
Copy the full SHA 1999b2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc020ee - Browse repository at this point
Copy the full SHA bc020eeView commit details -
This led to a nasty edgecase, where index reduction for modes that don't use the h3 table would have a degenerate table (size 4) allocated and marked clean, but which would not be re-indexed.
Configuration menu - View commit details
-
Copy full SHA for 7c57e2b - Browse repository at this point
Copy the full SHA 7c57e2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed4c2c6 - Browse repository at this point
Copy the full SHA ed4c2c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5707c8a - Browse repository at this point
Copy the full SHA 5707c8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff67c62 - Browse repository at this point
Copy the full SHA ff67c62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 194c542 - Browse repository at this point
Copy the full SHA 194c542View commit details -
Configuration menu - View commit details
-
Copy full SHA for a10c191 - Browse repository at this point
Copy the full SHA a10c191View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51d9066 - Browse repository at this point
Copy the full SHA 51d9066View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20c6907 - Browse repository at this point
Copy the full SHA 20c6907View commit details
Commits on Sep 16, 2019
-
Don't Include
sanitizer/msan_interface.h
, Since Not All Platforms P……rovide It Instead, explicitly declare the functions we use.
Configuration menu - View commit details
-
Copy full SHA for 72ea79c - Browse repository at this point
Copy the full SHA 72ea79cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.