-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to keep libzstd.a "as is" once created #2438
Conversation
to be compatible with scenarios such as `make -j allmost`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing
All tests fixed. |
Actually, disabling fuzzing + msan seems more difficult than anticipated, |
I'll open an issue on oss-fuzz about the msan failure. |
It looks like |
I think it should be possible to remove "memory" from the "sanitizer" list to turn off only Msan there: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 0e14345..5e5aae1 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -6,7 +6,7 @@ jobs:
strategy:
fail-fast: false
matrix:
- sanitizer: [address, undefined, memory]
+ sanitizer: [address, undefined]
steps:
- name: Build Fuzzers (${{ matrix.sanitizer }})
id: build Though I hope the issue will be fixed soon. |
That's a good point @evverx , |
to improve compatibility with parallel build scenarios such as
make -j allmost
.Presumed to fix #2436