Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trace] Minor fixes found during integration #2496

Merged
merged 1 commit into from
Feb 12, 2021
Merged

[trace] Minor fixes found during integration #2496

merged 1 commit into from
Feb 12, 2021

Conversation

terrelln
Copy link
Contributor

  • Mark ZSTD_CCtx_getParameter() as const
  • Add extern "C" guards to zstd_trace.h

@terrelln
[trace] Minor fixes found during integration
f520f6d 
* Mark `ZSTD_CCtx_getParameter()` as const
* Add `extern "C"` guards to `zstd_trace.h`
felixhandte
felixhandte approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@felixhandte felixhandte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda bothers me that you put the const in different places between the prototype and definition. But that's ok. :)

@terrelln terrelln merged commit 3ac842d into facebook:dev Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixhandte felixhandte felixhandte approved these changes

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terrelln @Cyan4973 @felixhandte @facebook-github-bot