Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ubsan test errors #2502

Merged
merged 2 commits into from
Feb 20, 2021
Merged

fix ubsan test errors #2502

merged 2 commits into from
Feb 20, 2021

Conversation

Cyan4973
Copy link
Contributor

allows recovering from pointer overflow.

@Cyan4973
fix ubsan test errors
9b07721 
allows recovering from pointer overflow
terrelln
terrelln approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@terrelln terrelln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this won't work with gcc versions older than 8.0.0, but that shouldn't be a problem.

@terrelln
Copy link
Contributor

I've fixed the LLVM fuzzers in #2503.

terrelln
terrelln reviewed Feb 19, 2021
View reviewed changes
Makefile Outdated
@@ -309,10 +309,10 @@ asan32: clean
$(MAKE) -C $(TESTDIR) test32 CC=clang MOREFLAGS="-g -fsanitize=address"

uasan: clean
$(MAKE) test CC=clang MOREFLAGS="-g -fno-sanitize-recover=all -fsanitize-recover=signed-integer-overflow -fsanitize=address,undefined -Werror"
$(MAKE) test CC=clang MOREFLAGS="-g -fno-sanitize-recover=all -fsanitize-recover=signed-integer-overflow -fsanitize-recover=pointer-overflow -fsanitize=address,undefined -Werror"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove -fsanitize-recover=signed-integer-overflow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
At least on my local platform, it works fine.

@Cyan4973 Cyan4973 merged commit c79411a into dev Feb 20, 2021
@Cyan4973 Cyan4973 deleted the ubsanfix branch May 4, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrelln terrelln terrelln approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cyan4973 @terrelln @facebook-github-bot