Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix & run overflow correction much more frequently in tests #2603

Merged
merged 1 commit into from
May 4, 2021

Commits on May 3, 2021

  1. Bug fix & run overflow correction much more frequently in tests

    * Fix overflow correction when `windowLog < cycleLog`. Previously, we
      got the correction wrong in this case, and our chain tables and binary
      trees would be corrupted. Now, we work as long as `maxDist` is a power
      of two, by adding `MAX(maxDist, cycleSize)` to our indices.
    * When `ZSTD_WINDOW_OVERFLOW_CORRECT_FREQUENTLY` is defined to non-zero
      run overflow correction as frequently as allowed without impacting
      compression ratio.
    * Enable `ZSTD_WINDOW_OVERFLOW_CORRECT_FREQUENTLY` in `fuzzer` and
      `zstreamtest` as well as all the OSS-Fuzz fuzzers. This has a 5-10%
      speed penalty at most, which seems reasonable.
    terrelln committed May 3, 2021
    Configuration menu
    Copy the full SHA
    34aff7e View commit details
    Browse the repository at this point in the history