Add 8 bytes to FSE_buildCTable wksp #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senhuang42
force-pushed
the
fse_wksp_fix
branch
from
8a5e0f3
to
ae08de6
Compare
terrelln
reviewed
Sep 1, 2021
terrelln
approved these changes
Sep 1, 2021
|
And apparently no "stack smashing" issue on |
senhuang42
force-pushed
the
fse_wksp_fix
branch
from
ae08de6
to
414e24b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes into the
spreadtable inFSE_buildCTable_wksp()may overwrite by up to 8 bytes, so enlarge the wksp by 8 bytes to account for this.