Smaller code with disabled features #2805
Conversation
Remove the then unneeded variables from the struct, and all accesses to them.
|
Hi @nolange! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
nolange
force-pushed
the
smaller_code_with_disabled_features
branch
from
77a1502
to
5bba2db
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Use an helper function, which will just return 0 in case the feature is disabled. Allows constant propagation and removal of dead code.
Multiple ZSTD_createDCtx* functions call other (public) ZSTD_createDCtx* functions, this makes it harder for humans and compilers to throw out code that is not used. This farms out the logic into a static function, if a program only uses a single ZSTD_createDCtx variant, all others can be easily dropped and the remaining implementation can be specialized.
nolange
force-pushed
the
smaller_code_with_disabled_features
branch
from
5241c89
to
6763f40
Compare
|
This first batch of modifications looks relatively straightforward to me. |
Hello,
Since zstd is everywhere nowadays, it would be time to get it into projects that pragmatically aim at code-size.
The aim of this series if to allow the developer a relatively easy way of dropping unused code, and the compiler to
propagate constants, partially specialize functions and remove a bigger junk of then dead code.
Since I expect some discussions covering all of those changes I put them into one pull request.