-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve help/usage (-h
, -H
) formatting
#3385
Conversation
Hi @jonpalmisc! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Hi @jonpalmisc, |
I agree, this is a good update. @jonpalmisc , if you have issues with the testing logic (which must be fixed before merge), |
Hey guys, thanks for the feedback; glad to hear these changes are a step in the right direction. I'll take a look at fixing that test. |
Looks to me like those two tests that were failing before pass now. Please let me know if you spot any other issues. I see the 'versions-compatibility' test is still failing but it seems like that is failing on most recent PRs; given that wasn't mentioned earlier, I assume that's a known/irrelevant issue? |
Yes, that's unrelated. |
Added in zstd by <facebook/zstd#3385> and in zstd v1.5.4. Fixes <https://rt.cpan.org/Public/Bug/Display.html?id=146465>.
Added in zstd by <facebook/zstd#3385> and in zstd v1.5.4. Fixes <https://rt.cpan.org/Public/Bug/Display.html?id=146465>.
Per our brief discussion in #3383, I've gone ahead and re-formatted the CLI help output. For convenience, I've attached text files containing the before/after of the help output.
Some main points with respect to the help formatting are:
I've also cleaned up the "welcome message" a bit in a separate commit; I expect this is an opinionated change and I did it in a separate commit so it can be easily reverted.
Please let me know your thoughts.
ZstdAfter.txt
ZstdBefore.txt