Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve help/usage (-h, -H) formatting #3385

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Improve help/usage (-h, -H) formatting #3385

merged 3 commits into from
Dec 21, 2022

Conversation

jonpalmisc
Copy link
Contributor

Per our brief discussion in #3383, I've gone ahead and re-formatted the CLI help output. For convenience, I've attached text files containing the before/after of the help output.

Some main points with respect to the help formatting are:

  • Flag/option descriptions now use proper capitalization and punctuation.
  • Flag/options descriptions are now consistently aligned and formatted.
  • Some non-technical references to 'zstd' have be rewritten to 'Zstandard'; the rationale here is that this output is for humans, and in instances where the compression algorithm rather than the CLI tool itself is being referred to, I think this makes sense.
  • Some flag/option descriptions have been rephrased slightly (or significantly) to what I think is better phrasing. Once again, this is opinionated and I'm happy to discuss changes.
  • Probably some more things I'm forgetting.

I've also cleaned up the "welcome message" a bit in a separate commit; I expect this is an opinionated change and I did it in a separate commit so it can be easily reverted.

Please let me know your thoughts.

ZstdAfter.txt
ZstdBefore.txt

@facebook-github-bot
Copy link

Hi @jonpalmisc!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Cyan4973 Cyan4973 self-assigned this Dec 20, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@yoniko
Copy link
Contributor

yoniko commented Dec 21, 2022

Hi @jonpalmisc,
I've only given it a brief look but it looks great from what I've seen.
Please note that there's a test that checks the help message and it's failing, so this PR will need to make the same changes to the expected help message in the tests, please see basic/help.sh* files for the test's details.

@Cyan4973
Copy link
Contributor

I agree, this is a good update.

@jonpalmisc , if you have issues with the testing logic (which must be fixed before merge),
I could also take over from here and modify the tests so they correspond to the new output format.

@jonpalmisc
Copy link
Contributor Author

Hey guys, thanks for the feedback; glad to hear these changes are a step in the right direction. I'll take a look at fixing that test.

@jonpalmisc
Copy link
Contributor Author

Looks to me like those two tests that were failing before pass now. Please let me know if you spot any other issues.

I see the 'versions-compatibility' test is still failing but it seems like that is failing on most recent PRs; given that wasn't mentioned earlier, I assume that's a known/irrelevant issue?

@Cyan4973
Copy link
Contributor

Yes, that's unrelated.
Thanks @jonpalmisc !

@Cyan4973 Cyan4973 merged commit 7607b96 into facebook:dev Dec 21, 2022
@Cyan4973 Cyan4973 mentioned this pull request Feb 9, 2023
zmughal added a commit to PerlAlien/Alien-zstd that referenced this pull request Feb 14, 2023
zmughal added a commit to PerlAlien/Alien-zstd that referenced this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants