Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logic when stderr is not the console #3458

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Update logic when stderr is not the console #3458

merged 2 commits into from
Jan 27, 2023

Commits on Jan 26, 2023

  1. modify cli-test logic : ignore stderr message by default 

    Previously, cli-test would, by default, check that a stderr output is strictly identical to a saved outcome.
When there was no instructions on how to interpret stderr, it would default to requiring it to be empty.

There are many tests cases though where stderr content doesn't matter, and we are mainly interested in the return code of the cli.
For these cases, it was possible to set a .ignore document, which would instruct to ignore stderr content.

This PR update the logic, to make .ignore the default.
When willing to check that stderr content is empty, one must now add an empty .strict file.

This will allow status message to evolve without triggering many cli-tests errors.
This is especially important when some of these status include compression results, which may change as a result of compression optimizations.
It also makes it easier to add new tests which only care about the CLI's return code.
    @Cyan4973
    Cyan4973 committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    3c21522 View commit details
    Browse the repository at this point in the history

  2. change logic when stderr is not console : don't update progress status 

    but keep warnings and final operation statement.

updated tests/cli-tests/ accordingly
    @Cyan4973
    Cyan4973 committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    82ca008 View commit details
    Browse the repository at this point in the history