-
Notifications
You must be signed in to change notification settings - Fork 924
Crashing bevore unobserve all in dealloc #46
Comments
Do you have sample code to reproduce this issue? |
unfortunately no :/ |
I'm a coworker of @mRs-, |
Ah, I see the issue now. You're creating a |
Ok i see the issue. Maybe the Correct me if I'm wrong. So the best thing we should make is to be sure to create an instance of |
Yeah, if you create it and store it in an ivar in the constructor you should be safe. |
Awesome! Thanks for your help Grant. |
Or, you could just remove the unobserveAll call. Because KVOController uses weak references, it's safe to just deallocate with it. |
that's even better 👍 |
The text was updated successfully, but these errors were encountered: