Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

Remove redundant if ...; err != nil checks #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidklassen
Copy link

Fixes golint warnings:

$ golint ./...
atomicfile.go:41:2: redundant if ...; err != nil check, just return error instead.
atomicfile.go:55:2: redundant if ...; err != nil check, just return error instead.

@davidklassen
Copy link
Author

It looks like vet command is no longer available under golang.org/x/tools/cmd package (see https://golang.org/doc/go1.2#go_tools_godoc). May be it makes sense to update go version in .travis.yml?

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants