This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Update webpack deps #2310
Closed
Update webpack deps #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiopro
reviewed
Jan 28, 2020
| @@ -71,7 +71,12 @@ var COPYRIGHT_HEADER = `/** | |||
| */ | |||
| `; | |||
|
|
|||
| var wpack = null; | |||
There was a problem hiding this comment.
Nit: can we rename this wpStream? I think it would be easier to reason about
claudiopro
approved these changes
Jan 28, 2020
|
Thanks for taking a look at this issue @mrkev ! Please take a look at my comment inline, not blocking on it though. |
There was a problem hiding this comment.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Sound good! I'll apply the changes internally through Phabricator and land it right away to keep things going. |
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: **Summary** This diff update build-related deps. We were creating more than one instance of `webpack-stream`, which is an error on the latest one, so I fix that too. **Test Plan** build && playground example Pull Request resolved: facebookarchive#2310 Differential Revision: D19598315 Pulled By: mrkev fbshipit-source-id: 5430f96576cadbd4f16b5a597dc77b9cc026d002
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: **Summary** This diff update build-related deps. We were creating more than one instance of `webpack-stream`, which is an error on the latest one, so I fix that too. **Test Plan** build && playground example Pull Request resolved: facebookarchive#2310 Differential Revision: D19598315 Pulled By: mrkev fbshipit-source-id: 5430f96576cadbd4f16b5a597dc77b9cc026d002
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** This diff update build-related deps. We were creating more than one instance of `webpack-stream`, which is an error on the latest one, so I fix that too. **Test Plan** build && playground example Pull Request resolved: facebookarchive/draft-js#2310 Differential Revision: D19598315 Pulled By: mrkev fbshipit-source-id: 5430f96576cadbd4f16b5a597dc77b9cc026d002
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This diff update build-related deps. We were creating more than one instance of
webpack-stream, which is an error on the latest one, so I fix that too.Test Plan
build && playground example