Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Update Overview.md #2434

Closed
wants to merge 1 commit into from
Closed

Conversation

abdellani
Copy link
Contributor

@abdellani abdellani commented May 19, 2020

Summary

Import Draft.css in the getting started example.

Import `Draft.css` in the getting started example.
@facebook-github-bot
Copy link

Hi @abdellani!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mrkev mrkev mentioned this pull request May 20, 2020
@claudiopro
Copy link
Contributor

claudiopro commented May 20, 2020

Thank you for this, it is clearly not obvious that the editor needs its Draft.css stylesheet to be imported for base styles to be applied.

While the intent of an import with a CSS file is quite clear, it may not work for everyone. What about calling out in the overview page that the user should import styles in Draft.css either directly or using their style framework of choice?

@facebook-github-bot
Copy link

@mrkev merged this pull request in e5e293f.

vilemj-Viclick pushed a commit to kontent-ai/draft-js that referenced this pull request Jul 16, 2020
Summary:
**Summary**

Import `Draft.css` in the getting started example.
Pull Request resolved: facebookarchive#2434

Reviewed By: claudiopro

Differential Revision: D21652152

Pulled By: mrkev

fbshipit-source-id: 27edcd7ec883fbb83c9dc06661ade9513f9f0b5d
alicayan008 pushed a commit to alicayan008/draft-js that referenced this pull request Jul 4, 2023
Summary:
**Summary**

Import `Draft.css` in the getting started example.
Pull Request resolved: facebookarchive/draft-js#2434

Reviewed By: claudiopro

Differential Revision: D21652152

Pulled By: mrkev

fbshipit-source-id: 27edcd7ec883fbb83c9dc06661ade9513f9f0b5d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants