Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Update to Xcode 8 Swift 3.0 syntax #55

Closed
wants to merge 4 commits into from

Conversation

gerbiljames
Copy link

This builds correctly in Xcode 8 and the sample app runs, but exhibits issue #51 in iOS 10 only, iOS 9.3 and earlier work correctly.

@ghost
Copy link

ghost commented Sep 13, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed The Facebook CLA has been signed label Sep 13, 2016
@ghost
Copy link

ghost commented Sep 13, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gerbiljames gerbiljames mentioned this pull request Sep 18, 2016
@nlutsenko
Copy link
Contributor

Superseded by #58. Thank you and sorry it took me a while to get back to this one with review.

@nlutsenko nlutsenko closed this Sep 22, 2016
@nlutsenko nlutsenko self-assigned this Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed The Facebook CLA has been signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants