From bd421839534f16eec4752396b3cce13f8ea8d256 Mon Sep 17 00:00:00 2001 From: Daniel Munoz Date: Wed, 20 Mar 2024 13:55:59 -0700 Subject: [PATCH] Fix ExceptionTests.Verify after enabling -Waddress flag Summary: -Waddress is about to be enabled, and it will cause a compilation error: ``` fbcode/dwio/alpha/common/tests/ExceptionTests.cpp:147:13: error: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Werror,-Wstring-compare] "a" == "b", ~~~ ^ ``` Differential Revision: D55153584 --- dwio/alpha/common/tests/ExceptionTests.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dwio/alpha/common/tests/ExceptionTests.cpp b/dwio/alpha/common/tests/ExceptionTests.cpp index 805bb18..3910b45 100644 --- a/dwio/alpha/common/tests/ExceptionTests.cpp +++ b/dwio/alpha/common/tests/ExceptionTests.cpp @@ -144,7 +144,7 @@ TEST(ExceptionTests, Assert) { TEST(ExceptionTests, Verify) { try { ALPHA_VERIFY_EXTERNAL( - "a" == "b", + 1 == 2, LocalFileSystem, alpha::error_code::NotSupported, true, @@ -156,7 +156,7 @@ TEST(ExceptionTests, Verify) { __FILE__, "", "TestBody", - "\"a\" == \"b\"", + "1 == 2", "error message3", "EXTERNAL", "NOT_SUPPORTED",