From 108152c78c32457704422bddc77961b7634e60de Mon Sep 17 00:00:00 2001
From: Deepak Majeti <deepak.majeti@ibm.com>
Date: Wed, 1 Jan 2025 13:57:35 -0500
Subject: [PATCH] fix

---
 .../hive/storage_adapters/hdfs/tests/HdfsFileSystemTest.cpp | 6 ++----
 .../hive/storage_adapters/hdfs/tests/HdfsMiniCluster.cpp    | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsFileSystemTest.cpp b/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsFileSystemTest.cpp
index 31ff93558fa63..168ca9abfb600 100644
--- a/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsFileSystemTest.cpp
+++ b/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsFileSystemTest.cpp
@@ -95,7 +95,7 @@ class HdfsFileSystemTest : public testing::Test {
 std::shared_ptr<filesystems::test::HdfsMiniCluster>
     HdfsFileSystemTest::miniCluster = nullptr;
 std::atomic<bool> HdfsFileSystemTest::startThreads = false;
-std::string HdfsFileSystemTest::fullDestinationPath_ = "";
+std::string HdfsFileSystemTest::fullDestinationPath_;
 
 void readData(ReadFile* readFile) {
   ASSERT_EQ(readFile->size(), 15 + kOneMB);
@@ -192,9 +192,7 @@ hdfsFS connectHdfsDriver(
     const std::string port) {
   filesystems::arrow::io::internal::LibHdfsShim* libhdfs_shim;
   auto status = filesystems::arrow::io::internal::ConnectLibHdfs(&libhdfs_shim);
-  if (!status.ok()) {
-    LOG(ERROR) << "ConnectLibHdfs failed ";
-  }
+  VELOX_CHECK(status.ok(), "ConnectLibHdfs failed.");
 
   // Connect to HDFS with the builder object
   hdfsBuilder* builder = libhdfs_shim->NewBuilder();
diff --git a/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsMiniCluster.cpp b/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsMiniCluster.cpp
index 8a3daecc3e491..3b41b217603e0 100644
--- a/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsMiniCluster.cpp
+++ b/velox/connectors/hive/storage_adapters/hdfs/tests/HdfsMiniCluster.cpp
@@ -94,7 +94,7 @@ void HdfsMiniCluster::addFile(std::string source, std::string destination) {
       source,
       destination);
   bool isExited =
-      filePutProcess->wait_for(std::chrono::duration<int, std::milli>(5000));
+      filePutProcess->wait_for(std::chrono::duration<int, std::milli>(15000));
   if (!isExited) {
     VELOX_FAIL(
         "Failed to add file to hdfs, exit code: {}",