-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix l_quantity
data generated by Tpch connector
#11511
Conversation
✅ Deploy Preview for meta-velox canceled.
|
@pramodsatya : Why is this fix only for l_quantity ? I see that other columns like lineitem.discount are also fixed with decimalToDouble. Do we not see inconsistencies with those columns ? |
@aditi-pandit, other double columns like lineitem.discount do not have an inconsistency for SF1 and they need the function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pramodsatya
@amitkdutta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pramodsatya for fixing it so quickly.
@amitkdutta merged this pull request in f1ff2df. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Resolves prestodb/presto#24010 .