fix: Build runner test only when VELOX_BUILD_TESTING enabled #11669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
assignUser
added
the
ready-to-merge
majetideepak
approved these changes
Nov 27, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in af20b93. |
TongWei1105
pushed a commit
to TongWei1105/velox
that referenced
this pull request
Dec 3, 2024
…kincubator#11669) Summary: A minor CMake fix for facebookincubator#11609, to address the linking issue when `VELOX_BUILD_TESTING` is off. ```C++ 20:52:36 facebookincubator#10 2.268 CMake Error at velox/velox/runner/tests/CMakeLists.txt:19 (target_link_libraries): 20:52:36 facebookincubator#10 2.268 Target "velox_local_runner_test" links to: 20:52:36 facebookincubator#10 2.268 20:52:36 facebookincubator#10 2.268 GTest::gtest 20:52:36 facebookincubator#10 2.268 20:52:36 facebookincubator#10 2.268 but the target was not found. Possible reasons include: 20:52:36 facebookincubator#10 2.268 20:52:36 facebookincubator#10 2.268 * There is a typo in the target name. 20:52:36 facebookincubator#10 2.268 * A find_package call is missing for an IMPORTED target. 20:52:36 facebookincubator#10 2.268 * An ALIAS target is missing. 20:52:36 facebookincubator#10 2.268 20:52:36 facebookincubator#10 2.268 20:52:36 facebookincubator#10 2.268 20:52:36 facebookincubator#10 2.273 CMake Generate step failed. Build files cannot be regenerated correctly. 20:52:36 facebookincubator#10 2.302 make: *** [Makefile:96: cmake-and-build] Error 1 20:52:36 facebookincubator#10 2.302 make: Leaving directory '/prestissimo' 20:52:36 facebookincubator#10 ERROR: process "/bin/sh -c EXTRA_CMAKE_FLAGS=${EXTRA_CMAKE_FLAGS} NUM_THREADS=${NUM_THREADS} make --directory=\"/prestissimo/\" cmake-and-build BUILD_TYPE=${BUILD_TYPE} BUILD_DIR=${BUILD_DIR} BUILD_BASE_DIR=${BUILD_BASE_DIR}" did not complete successfully: exit code: 2 ``` Pull Request resolved: facebookincubator#11669 Reviewed By: zacw7 Differential Revision: D66560342 Pulled By: xiaoxmeng fbshipit-source-id: 9f6b74c5a64f6e248cb8d86ec213ae76eb894770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor CMake fix for #11609, to address the linking issue when
VELOX_BUILD_TESTINGis off.