Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace master with main in velox/docs/README #12

Closed
wants to merge 1 commit into from
Closed

Replace master with main in velox/docs/README #12

wants to merge 1 commit into from

Conversation

mbasmanova
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 10, 2021
@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mbasmanova merged this pull request in a85abf9.

@pedroerp pedroerp mentioned this pull request Aug 18, 2021
Closed
This was referenced Oct 8, 2022
Closed
Closed
ZJie1 added a commit to ZJie1/velox that referenced this pull request Oct 25, 2022
@ZJie1
Merge pull request facebookincubator#12 from chaojun-zhang/WW43
62d9398 
[POAE7-2463] [M2] [Integration] [Velox To Substrait] Merge code from upstream velox
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Mar 22, 2023
@liujiayi771
fix sparksql decimal avg agg accuracy problem (facebookincubator#12)
0562e22
liujiayi771 added a commit to liujiayi771/velox that referenced this pull request Mar 22, 2023
@liujiayi771 @JkSelf
fix sparksql decimal avg agg accuracy problem (facebookincubator#12)
9ddcf41
liujiayi771 added a commit to liujiayi771/velox that referenced this pull request Mar 23, 2023
@liujiayi771 @JkSelf
fix sparksql decimal avg agg accuracy problem (facebookincubator#12)
fd7dbb9
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Mar 24, 2023
@liujiayi771 @JkSelf
fix sparksql decimal avg agg accuracy problem (facebookincubator#12)
5896bc7
rui-mo pushed a commit to rui-mo/velox that referenced this pull request Mar 27, 2023
@liujiayi771 @JkSelf
fix sparksql decimal avg agg accuracy problem (facebookincubator#12)
c30b97f
@billyean billyean mentioned this pull request Jun 7, 2023
Closed
@mayunlei mayunlei mentioned this pull request Jun 7, 2023
Open
PHILO-HE pushed a commit to PHILO-HE/velox that referenced this pull request Jul 10, 2023
@zhejiangxiaomai
Merge pull request facebookincubator#12 from yma11/zh
b4a9147 
update compare functions
@heary-cloud heary-cloud mentioned this pull request Dec 14, 2023
Open
facebook-github-bot pushed a commit that referenced this pull request Aug 23, 2024
@majetideepak @facebook-github-bot
Set CRC32 checksum algorithm for S3 multipart upload (#10801)
8d45b3c 
Summary:
The default algorithm used is MD5. However, MD5 is not supported with
fips and can cause a SIGSEGV. Set CRC32 instead which is a standard for
checksum computation and is not restricted by fips.
crc32 is also faster than md5.

Internally at IBM, we hit the following SIGSEGV

```
0x0000000000000000 in ?? ()
Missing separate debuginfos, use: dnf debuginfo-install openssl-fips-provider-3.0.7-2.el9.x86_64 xz-libs-5.2.5-8.el9_0.x86_64
(gdb) bt
#0  0x0000000000000000 in ?? ()
#1  0x0000000004e5f89b in Aws::Utils::Crypto::MD5OpenSSLImpl::Calculate(std::istream&) ()
#2  0x0000000004efd298 in Aws::Utils::Crypto::MD5::Calculate(std::istream&) ()
#3  0x0000000004ef71b9 in Aws::Utils::HashingUtils::CalculateMD5(std::iostream&) ()
#4  0x0000000004e8ebe8 in Aws::Client::AWSClient::AddChecksumToRequest(std::shared_ptr<Aws::Http::HttpRequest> const&, Aws::AmazonWebServiceRequest const&) const ()
#5  0x0000000004e8ed15 in Aws::Client::AWSClient::BuildHttpRequest(Aws::AmazonWebServiceRequest const&, std::shared_ptr<Aws::Http::HttpRequest> const&) const ()
#6  0x0000000004e977f9 in Aws::Client::AWSClient::AttemptOneRequest(std::shared_ptr<Aws::Http::HttpRequest> const&, Aws::AmazonWebServiceRequest const&, char const*, char const*, char const*) const ()
#7  0x0000000004e9e1c0 in Aws::Client::AWSClient::AttemptExhaustively(Aws::Http::URI const&, Aws::AmazonWebServiceRequest const&, Aws::Http::HttpMethod, char const*, char const*, char const*) const ()
#8  0x0000000004ea15e8 in Aws::Client::AWSXMLClient::MakeRequest(Aws::Http::URI const&, Aws::AmazonWebServiceRequest const&, Aws::Http::HttpMethod, char const*, char const*, char const*) const ()
#9  0x0000000004ea1f70 in Aws::Client::AWSXMLClient::MakeRequest(Aws::AmazonWebServiceRequest const&, Aws::Endpoint::AWSEndpoint const&, Aws::Http::HttpMethod, char const*, char const*, char const*) const ()
#10 0x0000000004de0933 in Aws::S3::S3Client::UploadPart(Aws::S3::Model::UploadPartRequest const&) const::{lambda()https://github.com/facebookincubator/velox/issues/1}::operator()() const ()
#11 0x0000000004de0b8c in std::_Function_handler<Aws::Utils::Outcome<Aws::S3::Model::UploadPartResult, Aws::S3::S3Error> (), Aws::S3::S3Client::UploadPart(Aws::S3::Model::UploadPartRequest const&) const::{lambda()https://github.com/facebookincubator/velox/issues/1}>::_M_invoke(std::_Any_data const&) ()
#12 0x0000000004e19317 in Aws::Utils::Outcome<Aws::S3::Model::UploadPartResult, Aws::S3::S3Error> smithy::components::tracing::TracingUtils::MakeCallWithTiming<Aws::Utils::Outcome<Aws::S3::Model::UploadPartResult, Aws::S3::S3Error> >(std::function<Aws::Utils::Outcome<Aws::S3::Model::UploadPartResult, Aws::S3::S3Error> ()>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, smithy::components::tracing::Meter const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
#13 0x0000000004d7cdcf in Aws::S3::S3Client::UploadPart(Aws::S3::Model::UploadPartRequest const&) const ()
#14 0x0000000004ca4aa6 in facebook::velox::filesystems::S3WriteFile::Impl::uploadPart (this=0x7fffec2f09a0, part=..., isLast=true)
    at /root/velox/velox/connectors/hive/storage_adapters/s3fs/S3FileSystem.cpp:380
```

Pull Request resolved: #10801

Reviewed By: amitkdutta

Differential Revision: D61671574

Pulled By: kgpai

fbshipit-source-id: 34c7b777b3fde0659ef74c4fbfd93740fdfa3f7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgpai kgpai Awaiting requested review from kgpai

@mshang816 mshang816 Awaiting requested review from mshang816

@pedroerp pedroerp Awaiting requested review from pedroerp

@amitkdutta amitkdutta Awaiting requested review from amitkdutta

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbasmanova @facebook-github-bot