Extract SubfieldFiltersBuilder from TableScanTest.cpp #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mbasmanova
force-pushed
the
extract-subfield-filter-builder
branch
from
cce9d82 to
03b68a0
Compare
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: SubfieldFiltersBuilder utility class as well as helper methods makeTableHandle() and allRegularColumns() methods would be handy in other tests, e.g. HashJoinTest. Pull Request resolved: facebookincubator/velox#137 Reviewed By: pedroerp Differential Revision: D30672730 Pulled By: mbasmanova fbshipit-source-id: 196841c236fcc66626c1926d708d7b29da022f37
|
This pull request was exported from Phabricator. Differential Revision: D30672730 |
mbasmanova
force-pushed
the
extract-subfield-filter-builder
branch
from
03b68a0 to
b6baeab
Compare
|
@mbasmanova merged this pull request in 9d97ce1. |
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 2, 2023
…ookincubator#137) * Fix might_contain validate fallback * add struct support
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 9, 2023
…ookincubator#137) * Fix might_contain validate fallback * add struct support
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Apr 1, 2023
…ookincubator#137) * Fix might_contain validate fallback * add struct support
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Apr 23, 2023
…ookincubator#137) * Fix might_contain validate fallback * add struct support
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 7, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function facebookincubator#148 Fix might_contain validate fallback and support struct literal facebookincubator#137 Implement datetime functions in velox/sparksql. facebookincubator#81 Parse options in SingularOrList correctly facebookincubator#48 Add SingularOrList support facebookincubator#45 Support if then in filter facebookincubator#74 Fix semi join output type and support existence join facebookincubator#67 Support decimal as partition column facebookincubator#167 Add the window support facebookincubator#61 Add expand operator facebookincubator#65 Support more cases of filter and its pushdown facebookincubator#14
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function facebookincubator#148 Fix might_contain validate fallback and support struct literal facebookincubator#137 Implement datetime functions in velox/sparksql. facebookincubator#81 Parse options in SingularOrList correctly facebookincubator#48 Add SingularOrList support facebookincubator#45 Support if then in filter facebookincubator#74 Fix semi join output type and support existence join facebookincubator#67 Support decimal as partition column facebookincubator#167 Add the window support facebookincubator#61 Add expand operator facebookincubator#65 Support more cases of filter and its pushdown facebookincubator#14
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function facebookincubator#148 Fix might_contain validate fallback and support struct literal facebookincubator#137 Implement datetime functions in velox/sparksql. facebookincubator#81 Parse options in SingularOrList correctly facebookincubator#48 Add SingularOrList support facebookincubator#45 Support if then in filter facebookincubator#74 Fix semi join output type and support existence join facebookincubator#67 Support decimal as partition column facebookincubator#167 Add the window support facebookincubator#61 Add expand operator facebookincubator#65 Support more cases of filter and its pushdown facebookincubator#14
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function facebookincubator#148 Fix might_contain validate fallback and support struct literal facebookincubator#137 Implement datetime functions in velox/sparksql. facebookincubator#81 Parse options in SingularOrList correctly facebookincubator#48 Add SingularOrList support facebookincubator#45 Support if then in filter facebookincubator#74 Fix semi join output type and support existence join facebookincubator#67 Support decimal as partition column facebookincubator#167 Add the window support facebookincubator#61 Add expand operator facebookincubator#65 Support more cases of filter and its pushdown facebookincubator#14
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function facebookincubator#148 Fix might_contain validate fallback and support struct literal facebookincubator#137 Implement datetime functions in velox/sparksql. facebookincubator#81 Parse options in SingularOrList correctly facebookincubator#48 Add SingularOrList support facebookincubator#45 Support if then in filter facebookincubator#74 Fix semi join output type and support existence join facebookincubator#67 Support decimal as partition column facebookincubator#167 Add the window support facebookincubator#61 Add expand operator facebookincubator#65 Support more cases of filter and its pushdown facebookincubator#14
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function facebookincubator#148 Fix might_contain validate fallback and support struct literal facebookincubator#137 Implement datetime functions in velox/sparksql. facebookincubator#81 Parse options in SingularOrList correctly facebookincubator#48 Add SingularOrList support facebookincubator#45 Support if then in filter facebookincubator#74 Fix semi join output type and support existence join facebookincubator#67 Support decimal as partition column facebookincubator#167 Add the window support facebookincubator#61 Add expand operator facebookincubator#65 Support more cases of filter and its pushdown facebookincubator#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubfieldFiltersBuilder utility class as well as helper methods makeTableHandle() and allRegularColumns() methods would be handy in other tests, e.g. HashJoinTest.