Don't depend on "common" registrations in sparksql directory #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Spark uses a variant of Murmur3; I've copied the hash implementation directly from the Spark codebase, modified of course for C++. The Spark algorithm for combining hashes is simple: initialize the hash to 42, and then use the current hash as the seed for the next hash. NULLs are skipped. This implementation processes one column at a time. Differential Revision: D29743513 fbshipit-source-id: c55c300ff824e6fc5ff15515393a02116b7dba92
Summary: Function registration is moved from FunctionBaseTest's constructor to SetUpTestCase(), which is once-per-process. Unittests were updated to rely on the SparkSQL registration functions, rather than do their own registration. Reviewed By: pedroerp Differential Revision: D30061756 fbshipit-source-id: f984329c8d93098ba9146d357b878848435942c0
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D30061756 |
|
This pull request has been merged in 9620d54. |
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Jun 15, 2022
* add date parsing * support extract year * support int32 return type
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Jun 24, 2022
* add date parsing * support extract year * support int32 return type
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Jun 30, 2022
* add date parsing * support extract year * support int32 return type
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Jul 20, 2022
* add date parsing * support extract year * support int32 return type
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Aug 2, 2022
* add date parsing * support extract year * support int32 return type
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Aug 12, 2022
* add date parsing * support extract year * support int32 return type
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Aug 22, 2022
* add date parsing * support extract year * support int32 return type
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Sep 7, 2022
* add date parsing * support extract year * support int32 return type
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Sep 26, 2022
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
This was referenced Oct 8, 2022
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Oct 26, 2022
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Nov 8, 2022
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Nov 8, 2022
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Nov 22, 2022
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Dec 15, 2022
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Jan 6, 2023
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Jan 12, 2023
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Feb 3, 2023
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Feb 24, 2023
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 3, 2023
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Mar 9, 2023
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Mar 27, 2023
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Apr 1, 2023
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Apr 23, 2023
* add date parsing * support extract year * support int32 return type * apply pr_19 use setted pool Parse and store the file format var into SubstraitVeloxPlanConverter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Function registration is moved from FunctionBaseTest's constructor to
SetUpTestCase(), which is once-per-process.
Unittests were updated to rely on the SparkSQL registration functions, rather than do their own registration.
Reviewed By: pedroerp
Differential Revision: D30061756