Add array vector reader for simple arrays #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
christycylee
force-pushed
the
export-D30048466
branch
from
6082a76 to
0121766
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30048466 |
christycylee
force-pushed
the
export-D30048466
branch
from
0121766 to
8c39196
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30048466 |
christycylee
force-pushed
the
export-D30048466
branch
from
8c39196 to
dbfae9e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30048466 |
christycylee
force-pushed
the
export-D30048466
branch
from
dbfae9e to
ab05882
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30048466 |
Summary: velox/experimental/codegen did not have its CMakeLists.txt set up properly, so some tests weren't ran when building with cmake. I had to disable one test, that will be addressed in the future. Pull Request resolved: facebookincubator/velox#26 Differential Revision: D30262438 Pulled By: christycylee fbshipit-source-id: 76937801aa82fe870c6b2234f91e2e3825928454
Differential Revision: D30024069 fbshipit-source-id: 5e9947058eac9efd781c1b6baae3b4b2f0acf564
Summary: Pull Request resolved: facebookincubator/velox#22 1. Added VectorReader for primitive types (e.g. array of fixed length types and array of varchar / varbin types). It is located in `velox/experimental/codegen/vector_function/ComplexVectorReader.h`. The class invokes the corresponding VectorReader on its elements. 2. Added `offset` as a parameter to primitive types' VectorReaders. This field is used by the complexType VectorReaders to locate the elements. 3. Added simple string VectorReader test. 4. Added Array VectorReader test. 5. Added VectorReaderTestBase. Differential Revision: D30048466 fbshipit-source-id: 2bee4f66f479631ded0352a7539c5bd78906c715
christycylee
force-pushed
the
export-D30048466
branch
from
ab05882 to
195beb4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30048466 |
This was referenced Oct 8, 2022
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
velox/experimental/codegen/vector_function/ComplexVectorReader.h. The class invokes the corresponding VectorReader on its elements.offsetas a parameter to primitive types' VectorReaders. This field is used by the complexType VectorReaders to locate the elements.Differential Revision: D30048466