Support configure default memory usage tracking through manager options #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…ns (facebookincubator#6587) Summary: Add to support configure default memory usage tracking through manager options. Prestissimo can use this to monitor the default memory usage such as disk spilling memory pool usage. Some dead code cleanup. Reviewed By: spershin Differential Revision: D49306305 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D49306305 |
|
@xiaoxmeng merged this pull request in 343a9b3. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…ns (facebookincubator#6587) Summary: Add to support configure default memory usage tracking through manager options. Prestissimo can use this to monitor the default memory usage such as disk spilling memory pool usage. Some dead code cleanup. Pull Request resolved: facebookincubator#6587 Reviewed By: spershin Differential Revision: D49306305 Pulled By: xiaoxmeng fbshipit-source-id: 0121c6ae1673495736d3425863dbe62012fac9d5
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…ns (facebookincubator#6587) Summary: Add to support configure default memory usage tracking through manager options. Prestissimo can use this to monitor the default memory usage such as disk spilling memory pool usage. Some dead code cleanup. Pull Request resolved: facebookincubator#6587 Reviewed By: spershin Differential Revision: D49306305 Pulled By: xiaoxmeng fbshipit-source-id: 0121c6ae1673495736d3425863dbe62012fac9d5
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…ns (facebookincubator#6587) Summary: Add to support configure default memory usage tracking through manager options. Prestissimo can use this to monitor the default memory usage such as disk spilling memory pool usage. Some dead code cleanup. Pull Request resolved: facebookincubator#6587 Reviewed By: spershin Differential Revision: D49306305 Pulled By: xiaoxmeng fbshipit-source-id: 0121c6ae1673495736d3425863dbe62012fac9d5
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
…ns (facebookincubator#6587) Summary: Add to support configure default memory usage tracking through manager options. Prestissimo can use this to monitor the default memory usage such as disk spilling memory pool usage. Some dead code cleanup. Pull Request resolved: facebookincubator#6587 Reviewed By: spershin Differential Revision: D49306305 Pulled By: xiaoxmeng fbshipit-source-id: 0121c6ae1673495736d3425863dbe62012fac9d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to support configure default memory usage tracking through manager
options. Prestissimo can use this to monitor the default memory usage such
as disk spilling memory pool usage.
Some dead code cleanup.