Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove object subclasses from Python classes. #250

Merged

Conversation

ChrisCummins
Copy link
Contributor

The minimum supported Python version for CompilerGym is
3.6. Subclassing from object is only required for Python versions < 3.

The minimum supported Python version for CompilerGym is
3.6. Subclassing from object is only required for Python versions < 3.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #250 (731bf43) into development (e9d0937) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #250   +/-   ##
============================================
  Coverage        81.02%   81.02%           
============================================
  Files               76       76           
  Lines             4337     4337           
============================================
  Hits              3514     3514           
  Misses             823      823           
Impacted Files Coverage Δ
compiler_gym/datasets/benchmark.py 88.17% <100.00%> (ø)
compiler_gym/datasets/dataset.py 83.62% <100.00%> (ø)
compiler_gym/datasets/datasets.py 93.15% <100.00%> (ø)
compiler_gym/envs/llvm/llvm_benchmark.py 87.40% <100.00%> (ø)
compiler_gym/service/connection.py 74.15% <100.00%> (ø)
compiler_gym/third_party/inst2vec/__init__.py 93.33% <100.00%> (ø)
compiler_gym/util/shell_format.py 100.00% <100.00%> (ø)
compiler_gym/util/timer.py 100.00% <100.00%> (ø)
compiler_gym/views/observation.py 92.85% <100.00%> (ø)
compiler_gym/views/observation_space_spec.py 83.52% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d0937...731bf43. Read the comment docs.

@ChrisCummins ChrisCummins merged commit 616fd13 into facebookresearch:development May 5, 2021
@ChrisCummins ChrisCummins deleted the new-classes branch May 5, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants