Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to demonstrate #587 #589

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

ChrisCummins
Copy link
Contributor

@ChrisCummins ChrisCummins commented Mar 1, 2022

Adds a test to repro #587. Credit to @uduse for reporting this.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #589 (fa05914) into development (d5d60b6) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #589      +/-   ##
===============================================
+ Coverage        88.26%   88.37%   +0.10%     
===============================================
  Files              114      114              
  Lines             6708     6708              
===============================================
+ Hits              5921     5928       +7     
+ Misses             787      780       -7     
Impacted Files Coverage Δ
compiler_gym/views/observation_space_spec.py 85.71% <0.00%> (-3.58%) ⬇️
compiler_gym/views/observation.py 97.29% <0.00%> (-2.71%) ⬇️
...loop_tool/service/loop_tool_compilation_session.py 87.75% <0.00%> (-2.05%) ⬇️
compiler_gym/envs/compiler_env.py 91.33% <0.00%> (-1.00%) ⬇️
compiler_gym/util/truncate.py 96.29% <0.00%> (+3.70%) ⬆️
compiler_gym/service/connection.py 82.95% <0.00%> (+4.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d60b6...fa05914. Read the comment docs.

@ChrisCummins ChrisCummins merged commit 0b881cb into facebookresearch:development Mar 7, 2022
@ChrisCummins ChrisCummins deleted the fix/587 branch March 7, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants