Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Reduce severity of logging messages on reset() retry. #602

Merged

Conversation

ChrisCummins
Copy link
Contributor

If env.reset() fails, log the error that we are recovering from, but treat ServiceIsClosed errors as unimportant since we know what causes them.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #602 (b11c5f0) into development (d5d60b6) will decrease coverage by 0.04%.
The diff coverage is 97.95%.

❗ Current head b11c5f0 differs from pull request most recent head 9a48937. Consider uploading reports for the commit 9a48937 to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #602      +/-   ##
===============================================
- Coverage        88.26%   88.22%   -0.05%     
===============================================
  Files              114      114              
  Lines             6708     6709       +1     
===============================================
- Hits              5921     5919       -2     
- Misses             787      790       +3     
Impacted Files Coverage Δ
compiler_gym/envs/llvm/__init__.py 100.00% <ø> (ø)
compiler_gym/envs/llvm/llvm_env.py 88.18% <ø> (ø)
compiler_gym/service/proto/__init__.py 100.00% <ø> (ø)
compiler_gym/third_party/inst2vec/rgx_utils.py 86.53% <ø> (ø)
compiler_gym/service/connection.py 78.03% <75.00%> (ø)
compiler_gym/envs/compiler_env.py 91.85% <100.00%> (-0.48%) ⬇️
compiler_gym/envs/llvm/datasets/cbench.py 80.74% <100.00%> (ø)
compiler_gym/envs/llvm/datasets/csmith.py 86.84% <100.00%> (ø)
compiler_gym/envs/llvm/llvm_benchmark.py 93.43% <100.00%> (ø)
...ice/runtime/create_and_run_compiler_gym_service.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d60b6...9a48937. Read the comment docs.

@ChrisCummins ChrisCummins requested a review from hughleat March 6, 2022 22:16
@ChrisCummins ChrisCummins merged commit 2f35c68 into facebookresearch:development Mar 9, 2022
@ChrisCummins ChrisCummins deleted the feature/retry-log branch March 9, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants