Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplicaCAD v1.6 #1783

Merged
merged 2 commits into from
Jun 1, 2023
Merged

ReplicaCAD v1.6 #1783

merged 2 commits into from
Jun 1, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jun 13, 2022 •
edited
Loading

Motivation and Context

New version 1.6 of ReplicaCAD includes the following changes:

How Has This Been Tested

local

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from ASzot June 13, 2022 22:44
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 13, 2022
@aclegg3
Copy link
Contributor Author

aclegg3 commented Aug 24, 2022

@ASzot with the challenge launched, let's consider merging this dataset update with additional receptacles. When you have time, maybe run a quick test and let me know if you see anything problematic.

@aclegg3 aclegg3 requested review from jturner65 and removed request for ASzot June 1, 2023 20:25
jturner65
jturner65 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once more with feeling!
LGTM!

@aclegg3 aclegg3 merged commit d0797d3 into main Jun 1, 2023
@aclegg3 aclegg3 deleted the replica-cad-v1.6 branch June 1, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @jturner65 @facebook-github-bot