Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port stage_requires_lighting arg to python viewer #1807

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jul 11, 2022

Motivation and Context

This argument allows terminal override of stage lighting defaults to enable synthetic lighting for scenes which require it but may not be configured to use it automatically.

How Has This Been Tested

Locally with stage assets which crash when rendered with flat shader.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 11, 2022
@aclegg3 aclegg3 merged commit d58d23f into main Jul 11, 2022
@aclegg3 aclegg3 deleted the viewer-py-stage-requires-lighting branch July 11, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants