Update Magnum submodules to latest, fix AssimpImporter assertion #1911
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly includes a change to AssimpImporter that avoids returning a growable array which is problematic when a static plugin gets used across more than one dynamic library.
facebook-github-bot
added
the
CLA Signed
Skylion007
approved these changes
Oct 24, 2022
0mdc
approved these changes
Oct 24, 2022
jrreyna
added a commit
that referenced
this pull request
Oct 25, 2022
Merging from PR: "Update Magnum submodules to latest, fix AssimpImporter assertion #1911" to bring Mosra's AssetImporter fix into my branch
jrreyna
added a commit
that referenced
this pull request
Oct 25, 2022
…orter assertion #1911' into my branch to fix an assertion error with AssetImporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Mainly includes a change to AssimpImporter that avoids returning a growable array. Which is problematic when a static plugin gets used across more than one dynamic library, leading to the following assertion:
Details in mosra/magnum-plugins@10b7e94.
How Has This Been Tested
My CIs pass,⚠️ however ⚠️ there's a very slight chance that the change could make previously-silently-wrongly-imported models now assert -- tighter checks in the plugin could trigger potential new Assimp bugs. So please verify with any OBJ/PLY/STL/COLLADA models you have, as well as the one that caused the above assertion in the first place.
Types of changes