Batch renderer integration into Python viewer. #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there's already an API to change the transformation of a hierarchy right after it's added, this parameter was kinda redundant. But I need to have a way to set an initial "coordinate frame correction" transformation and keep it there, forever, which is what this parameter could do instead -- so now it applies the transform to the immediate child nodes instead, leaving the top-level transformation as an identity.
Need this to achieve a pixel-perfect correspondence with the classic renderer.
Need this for a scenegraph-less rendering.
It was in the CUDA interop test already but that one isn't ran on non-CUDA builds.
I don't intend these to be used that much, nevertheless it's good to not do stupidly inefficient things such as allocating and then copying a huge buffer every frame just because "it's fine for a test". It also allows for easy querying of image subranges, which is a nice bonus.
Generalizes blitRgbaToDefault(), which was a bit too limited.
…rge it cleanly. Because there's a thing called clang-format which makes any clean merges just straight impossible. Yay!
The public base class interface is now non-virtual, which allows it to perform various checks before delegating into the concrete implementation. Which allows the implementations to omit all checks that would otherwise be duplicated between them.
Also putting that back to a single file -- a Player can't really be used without the implementation class anyway so a separate header doesn't make sense. The light setup and semantic ID setting is optional, with the default implementation being a no-op. Also changed gfx::replay::GfxReplayNode* to gfx::replay::NodeHandle. It's shorter and the pointer is a part of the typedef, thus removing a potential ambiguity about whether one should use a * with this type or not.
…ble. The comment stays there though, for historical records.
…h. Mesh are loaded without renderer for physics already.
…o python-viewer-batch-renderer
0mdc
changed the title
0mdc
commented
Dec 19, 2022
| CORRADE_ASSERT( | ||
| !Magnum::GL::Context::hasCurrent(), | ||
| "Simulator::reconfigure() : Unexpected existing context when " | ||
| "createRenderer==false", ); |
There was a problem hiding this comment.
I removed this assert as it is obsolete.
In this case, a context exists (GLFW) but the simulators are headless.
mosra
approved these changes
Dec 21, 2022
0mdc
force-pushed
the
python-viewer-batch-renderer
branch
from
928a19f
to
7724832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This changeset integrates the batch renderer into the Python viewer.
New command line args:
--enable-batch-rendererenables batch rendering.--num-environmentsspecifies the number of concurrent environments to render.--width,--heightspecify the window resolution.--composite-filesallows to pass composite gltf files to Magnum.Example usage:
python examples/viewer.py --enable-batch-renderer --num-environments 6 --width 1024 --height 896 --scene "data/scene_datasets/habitat-test-scenes/skokloster-castle.glb"python examples/viewer.py --enable-batch-renderer --num-environments 64 --width 1024 --height 1024How Has This Been Tested
This was tested locally, and in automated tests here: #1947.
No regression found when testing the viewer with the classical renderer.
Types of changes
Checklist