Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pytorch-CUDA dependency on CI. #1973

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Fix Pytorch-CUDA dependency on CI. #1973

merged 3 commits into from
Dec 21, 2022

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Dec 20, 2022 •
edited
Loading

Motivation and Context

This fixes the ongoing Pytorch-CUDA CI issue by enforcing specific Anaconda dependencies.
A CI stage was also added for early validation of installed libraries.

How Has This Been Tested

Tested through CI.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 20, 2022
@0mdc 0mdc force-pushed the torch-ci-fix branch 2 times, most recently from 1c4dd98 to 4e7a8e1 Compare December 20, 2022 15:38
@0mdc 0mdc force-pushed the torch-ci-fix branch 3 times, most recently from bfd1fd2 to 453e539 Compare December 20, 2022 17:05
@0mdc 0mdc force-pushed the torch-ci-fix branch 5 times, most recently from 92d97a5 to afc713a Compare December 20, 2022 18:00
Skylion007
Skylion007 reviewed Dec 20, 2022
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@0mdc 0mdc changed the title Attempt to fix CUDA torch dependency on CI. Fix pytorch-CUDA dependency on CI. Dec 21, 2022
@0mdc 0mdc changed the title Fix pytorch-CUDA dependency on CI. Fix Pytorch-CUDA dependency on CI. Dec 21, 2022
@0mdc 0mdc marked this pull request as ready for review December 21, 2022 03:59
mosra
mosra approved these changes Dec 21, 2022
View reviewed changes
Copy link
Collaborator

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, especially the early validation check is a great idea.

@0mdc 0mdc merged commit 8f12b90 into main Dec 21, 2022
@0mdc 0mdc deleted the torch-ci-fix branch December 22, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosra mosra mosra approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0mdc @mosra @Skylion007 @facebook-github-bot