Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix standalone batch renderer context deletion. #2043

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fix standalone batch renderer context deletion. #2043

merged 1 commit into from
Mar 22, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 22, 2023

Motivation and Context

This fixes RendererStandalone leaking its context.

How Has This Been Tested

Tested on Habitat-Lab and updated replay batch renderer test.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested review from mosra and eundersander March 22, 2023 20:23
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 22, 2023
@0mdc 0mdc changed the title Fix batch renderer context deletion issue with standalone renderer. Fix standalone batch renderer context deletion. Mar 22, 2023
@0mdc 0mdc mentioned this pull request Mar 22, 2023
Merged
5 tasks
mosra
mosra reviewed Mar 22, 2023
View reviewed changes
src/tests/BatchReplayRendererTest.cpp
#endif
}
// Check that the context is properly deleted
CORRADE_VERIFY(!Mn::GL::Context::hasCurrent());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea with the check 👍

@0mdc 0mdc merged commit 2b0e0b4 into main Mar 22, 2023
@0mdc 0mdc mentioned this pull request Apr 11, 2023
Closed
5 tasks
@0mdc 0mdc deleted the destroy-context branch May 29, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosra mosra mosra approved these changes

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @mosra @facebook-github-bot