Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: typing - make optionals explicit #2118

Merged
merged 2 commits into from
May 28, 2023
Merged

chore: typing - make optionals explicit #2118

merged 2 commits into from
May 28, 2023
+5 −4

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • This makes all our optionals explicit with improve the documentation. I also turned on the feature in mypy. This produces better documentation and is less likely to hide issues with mypy. It also is the default in newer mypy versions.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 28, 2023
@Skylion007 Skylion007 changed the title Skylion007/make optional explicit Make optional explicit May 28, 2023
@Skylion007 Skylion007 changed the title Make optional explicit chore: typing - make optionals explicit May 28, 2023
@Skylion007 Skylion007 merged commit dfdc577 into main May 28, 2023
@Skylion007 Skylion007 deleted the skylion007/make-optional-explicit branch May 28, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @0mdc @facebook-github-bot