-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replay renderer partial deletion #2136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. Let me know when I should take another look!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a unit test that will trigger this code? BatchReplayRendererTest::testIntegration is close but it doesn't do any deletions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -0,0 +1,169 @@ | |||
// Copyright (c) Meta Platforms, Inc. and its affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this code was moved from BatchReplayRenderer.cpp
without changes so I'm not looking closely at this file.
Motivation and Context
The batch renderer can only delete full scenes - it cannot delete single objects.
To circumvent this, deletions are processed as such:
How Has This Been Tested
Tested locally on PPO training and added a unit test.
Types of changes
Checklist