Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pybind11 to v2.11.1 #2166

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Update pybind11 to v2.11.1 #2166

merged 1 commit into from
Jul 26, 2023

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • Update pybind11 with fixes and experimental python 3.12 support

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 25, 2023
aclegg3
aclegg3 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once tests pass, we can merge.

@aclegg3 aclegg3 merged commit f407dd9 into main Jul 26, 2023
@aclegg3 aclegg3 deleted the Skylion007/update-pybind11-to-v2.11.1 branch July 26, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@dhruvbatra dhruvbatra Awaiting requested review from dhruvbatra

@eundersander eundersander Awaiting requested review from eundersander

@0mdc 0mdc Awaiting requested review from 0mdc

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @aclegg3 @facebook-github-bot