Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hab3_bench_assets datasource #2234

Merged
merged 1 commit into from
Oct 10, 2023
Merged

hab3_bench_assets datasource #2234

merged 1 commit into from
Oct 10, 2023
+6 −0

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Oct 10, 2023

Motivation and Context

Adds the habitat 3.0 benchmark assets datasource to the datasets_downloader util.

How Has This Been Tested

Locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 10, 2023
jimmytyyang
jimmytyyang approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@jimmytyyang jimmytyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aclegg3 aclegg3 merged commit b3c0552 into main Oct 10, 2023
4 of 10 checks passed
@aclegg3 aclegg3 deleted the hab3-bench-datasource branch October 10, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@jimmytyyang jimmytyyang jimmytyyang approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@xavierpuigf xavierpuigf Awaiting requested review from xavierpuigf

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aclegg3 @jimmytyyang @0mdc @facebook-github-bot