-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RTLD_GLOBAL flag from apps. #2312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
52908f3
to
5879164
Compare
5879164
to
a36e63c
Compare
FYI - this breaks usage of magnum importers from outside We're either going to drop support of PLY or move that function to sim. Until then, this PR will stay open. FYI @jturner65 , @aclegg3 Edit: This is fixed here: facebookresearch/habitat-lab#1869 |
a36e63c
to
ca175e7
Compare
Motivation and Context
This removes the
RTLD_GLOBAL
flag from python apps, which is no longer required since this magnum update.The flag is also set in
habitat-sim
's__init__.py
to handle cases wherehabitat-sim
bindings are used beforemagnum
/corrade
is imported.This flag was required before loading native magnum/habitat modules to de-duplicate globals across shared modules. This is now done automatically when importing corrade..
This PR does the same changes in
habitat-lab
.How Has This Been Tested
Tested the viewers locally on Linux.
Types of changes
Checklist