Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RTLD_GLOBAL flag from apps. #2312

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Remove RTLD_GLOBAL flag from apps. #2312

merged 4 commits into from
Mar 18, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jan 31, 2024

Motivation and Context

This removes the RTLD_GLOBAL flag from python apps, which is no longer required since this magnum update.

The flag is also set in habitat-sim's __init__.py to handle cases where habitat-sim bindings are used before magnum/corrade is imported.

This flag was required before loading native magnum/habitat modules to de-duplicate globals across shared modules. This is now done automatically when importing corrade..

This PR does the same changes in habitat-lab.

How Has This Been Tested

Tested the viewers locally on Linux.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 31, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0mdc 0mdc force-pushed the remove-rtld-global branch 3 times, most recently from 52908f3 to 5879164 Compare February 2, 2024 01:07
@0mdc
Copy link
Contributor Author

0mdc commented Mar 15, 2024

FYI - this breaks usage of magnum importers from outside habitat-sim. There only one instance of this, which is the following:
https://github.com/facebookresearch/habitat-lab/blob/main/habitat-lab/habitat/datasets/rearrange/samplers/receptacle.py#L528

We're either going to drop support of PLY or move that function to sim. Until then, this PR will stay open.

FYI @jturner65 , @aclegg3

Edit: This is fixed here: facebookresearch/habitat-lab#1869

@0mdc 0mdc merged commit d890c64 into main Mar 18, 2024
10 checks passed
@0mdc 0mdc deleted the remove-rtld-global branch March 18, 2024 23:48
0mdc added a commit that referenced this pull request Mar 20, 2024
0mdc added a commit that referenced this pull request Mar 20, 2024
0mdc added a commit that referenced this pull request Apr 23, 2024
0mdc added a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants