--Support marker set specifications in Object, Stage and AO config jsons #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the process initially built for the user-defined configurations.
Supports arrays of strings, objects and nested arrays, as well as numeric arrays with lengths different than currently support magnum vectors and matrices. Values are stored within a subconfig, keyed by a constructed key of "<subconfig_key>_<ara_idx>"
facebook-github-bot
added
the
CLA Signed
Following the paradigm of user-defined attributes.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR supports the loading, modification, and saving of nested marker sets in the configs for AO, objects and stages.
How Has This Been Tested
Local C++ and python tests pass
Types of changes
Checklist