Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--MarkerSets assignment to objects, 'interface' class and bindings #2371

Merged
merged 32 commits into from
May 1, 2024

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Apr 25, 2024

Motivation and Context

This PR expands on the Markersets support added in this PR to make interaction with Markersets easier.

  • Introduces a set of classes (MarkerSets, MarkerSet, LinkMarkerSets ,LinkMarkerSubset) to map convenience functions to a MarkerSets Configuration hierarchy, including python bindings. These functions include querying, accessing and removing nested configurations as well as adding marker points to any marker subset.
  • Adds Stage/Object/Articulated Object support for saving the markersets present from the initialization attributes used to create the object.
  • Adds functionality to transform a list of points from ao/object local space to global, and vice versa.
  • Adds saving of scale as a vector for all constructs (ao's, objects and stages) on their creation.

How Has This Been Tested

Locally c++ and python tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 25, 2024
@jturner65 jturner65 requested a review from aclegg3 April 25, 2024 17:02
This function will replace the original keys for all the values in a configuration (regardless of type) with sequential numeric strings preserving the natural ordering of the original set of keys
The constructed key for array values is formatted  with a fixed-width leading-zero numeric string so that it will always sort properly.
@jturner65 jturner65 marked this pull request as ready for review April 29, 2024 16:58
@jturner65 jturner65 changed the title --[WIP]MarkerSets assignment to objects, 'interface' class and bindings --MarkerSets assignment to objects, 'interface' class and bindings Apr 29, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Some nits and questions.
Mostly docstring typos.

src/esp/bindings/AttributesBindings.cpp Show resolved Hide resolved
src/esp/bindings/PhysicsObjectBindings.cpp Outdated Show resolved Hide resolved
src/esp/bindings/AttributesBindings.cpp Outdated Show resolved Hide resolved
src/esp/bindings/AttributesBindings.cpp Outdated Show resolved Hide resolved
src/esp/bindings/AttributesBindings.cpp Outdated Show resolved Hide resolved
src/esp/physics/ArticulatedObject.h Outdated Show resolved Hide resolved
src/esp/physics/ArticulatedObject.h Outdated Show resolved Hide resolved
src/esp/physics/ArticulatedObject.h Outdated Show resolved Hide resolved
src/esp/physics/PhysicsObjectBase.h Outdated Show resolved Hide resolved
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed my comments. Thanks!

@jturner65 jturner65 merged commit 2ac5b9f into main May 1, 2024
10 checks passed
@jturner65 jturner65 deleted the MarkerSubsetsHandling2 branch May 1, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants