-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--MarkerSets assignment to objects, 'interface' class and bindings #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Apr 25, 2024
jturner65
force-pushed
the
MarkerSubsetsHandling2
branch
from
April 25, 2024 19:23
582c403
to
e2f746a
Compare
Intended to provide convenience access to markersets hierarchy
jturner65
force-pushed
the
MarkerSubsetsHandling2
branch
from
April 26, 2024 10:58
7e64d77
to
ee811b1
Compare
This function will replace the original keys for all the values in a configuration (regardless of type) with sequential numeric strings preserving the natural ordering of the original set of keys
The constructed key for array values is formatted with a fixed-width leading-zero numeric string so that it will always sort properly.
jturner65
force-pushed
the
MarkerSubsetsHandling2
branch
from
April 26, 2024 18:41
30564a5
to
cf99b77
Compare
This is not currently available for an ArticulatedLink and as it is it would break if ever attempted.
jturner65
changed the title
--[WIP]MarkerSets assignment to objects, 'interface' class and bindings
--MarkerSets assignment to objects, 'interface' class and bindings
Apr 29, 2024
11 tasks
aclegg3
requested changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Some nits and questions.
Mostly docstring typos.
jturner65
force-pushed
the
MarkerSubsetsHandling2
branch
from
May 1, 2024 17:54
da4d795
to
b76dd95
Compare
jturner65
force-pushed
the
MarkerSubsetsHandling2
branch
from
May 1, 2024 17:56
b76dd95
to
f679ff4
Compare
aclegg3
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed my comments. Thanks!
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR expands on the Markersets support added in this PR to make interaction with Markersets easier.
How Has This Been Tested
Locally c++ and python tests pass.
Types of changes
Checklist