Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Move AssetType enum class attributes namespace #2386

Merged
merged 2 commits into from
May 8, 2024

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR moves the AssetType enum from the asset namespace to the metadata::attributes namespace where it can reside with the other metadata-related enum classes in AttributesEnumMaps. This is primarily for consistency but also to facilitate interactions with the enum-backed data in the Attributes that consume it.

The PR also moves the EMPTY_SCENE definition to Esp.h from Asset.h, in an effort to also maintain consistency in where our system-wide consts are stored.

How Has This Been Tested

Locally c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 May 7, 2024 15:14
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 7, 2024
* @brief loading an asset info with filepath == EMPTY_SCENE creates a scene
* graph with no scene mesh (ie. an empty scene)
*/
constexpr char EMPTY_SCENE[] = "NONE";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@jturner65 jturner65 merged commit 7403422 into main May 8, 2024
9 of 10 checks passed
@jturner65 jturner65 deleted the Attr_AssetTypeRefactor branch May 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants