--Move AssetType enum class attributes namespace #2386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR moves the AssetType enum from the asset namespace to the metadata::attributes namespace where it can reside with the other metadata-related enum classes in AttributesEnumMaps. This is primarily for consistency but also to facilitate interactions with the enum-backed data in the Attributes that consume it.
The PR also moves the EMPTY_SCENE definition to Esp.h from Asset.h, in an effort to also maintain consistency in where our system-wide consts are stored.
How Has This Been Tested
Locally c++ and python tests pass
Types of changes
Checklist