Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BUGFIX] - Properly set instance user config from base passed base config. #2407

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR properly copies the user defined attributes from a base config to an instance config's user-defined subconfig, instead of in the subconfig's base level.

How Has This Been Tested

Local c++ and python tests

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 June 11, 2024 15:23
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 11, 2024
@jturner65 jturner65 force-pushed the Bugfix_InstanceFromObjConfig branch from ce9eca0 to 18a2ba6 Compare June 12, 2024 12:46
@jturner65 jturner65 force-pushed the Bugfix_InstanceFromObjConfig branch from bed1ba6 to 6139210 Compare June 13, 2024 13:31
@jturner65 jturner65 merged commit ca1494b into main Jun 13, 2024
10 checks passed
@jturner65 jturner65 deleted the Bugfix_InstanceFromObjConfig branch June 13, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants