Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BE] - Add utility function to specify whether object is ao or not #2416

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This small PR exposes a read-only property ("is_articulated") in the python bindings that says whether an object is articulated or not, as an alternative to checking for the object type before attempting to access type-specific functions.

How Has This Been Tested

c++ PhysicsTest.cpp and SimTest.cpp and python test_physics.py have been expanded to test this field, and all tests pass locally.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 June 25, 2024 19:13
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 25, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
Should eliminate our frequent need for isinstance(ManagedArticulatedObject).

@jturner65 jturner65 merged commit 549e151 into main Jun 26, 2024
9 of 10 checks passed
@jturner65 jturner65 deleted the BE_HelperUtilities branch June 26, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants