Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[BE] - Remove deprecated Sim-level contact test #2417

Merged
merged 2 commits into from
Jun 27, 2024
Merged

--[BE] - Remove deprecated Sim-level contact test #2417

merged 2 commits into from
Jun 27, 2024
+2 −45

Conversation

jturner65
Copy link
Contributor

Motivation and Context

The sim/physics manager version of contact test has been deprecated since before Habitat 2.0 was released, and should have been removed then. This PR removes it.

How Has This Been Tested

All c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 June 27, 2024 14:10
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 27, 2024
aclegg3
aclegg3 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup 👍

@jturner65 jturner65 merged commit cda316f into main Jun 27, 2024
9 of 10 checks passed
@jturner65 jturner65 deleted the BE_ContactTestDeprecation branch June 27, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jturner65 @aclegg3 @facebook-github-bot