Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] github actions migration #2422

Open
wants to merge 81 commits into
base: main
Choose a base branch
from
Open

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jul 2, 2024

Motivation and Context

Working branch to test migration to github actions. Do not merge.

How Has This Been Tested

WIP

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 added the do not merge Not ready to merge. This label should block merging. label Jul 2, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 2, 2024
@0mdc 0mdc self-requested a review November 13, 2024 16:02
@0mdc 0mdc mentioned this pull request Nov 15, 2024
11 tasks
@0mdc
Copy link
Contributor

0mdc commented Nov 18, 2024

@aclegg3 EGL initialization on the Actions runner now works correctly. You may still have issues with the CUDA build - let me know if that happens.

Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some high-level comments.

- name: setup
run: |-
pip install -U pip
pip install -U --prefer-binary \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should pin all dependencies here, especially complex ones like numpy.
This could be done from a requirements_ci.txt file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

# Disable clone protection for git lfs
export GIT_CLONE_PROTECTION_ACTIVE=false

sudo apt install git-lfs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move LFS installation to a separate actions.yml workflow, along with all other basic setup steps.

python src_python/habitat_sim/utils/datasets_download.py --uids ci_test_assets ycb rearrange_dataset_v2 --replace --data-path data/ --no-prune
ls -la data/scene_datasets/habitat-test-scenes/
- name: Debugging with tmate
uses: mxschmitt/action-tmate@v3.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really handy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. do not merge Not ready to merge. This label should block merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants