-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] github actions migration #2422
base: main
Are you sure you want to change the base?
Conversation
@aclegg3 EGL initialization on the Actions runner now works correctly. You may still have issues with the CUDA build - let me know if that happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some high-level comments.
- name: setup | ||
run: |- | ||
pip install -U pip | ||
pip install -U --prefer-binary \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should pin all dependencies here, especially complex ones like numpy
.
This could be done from a requirements_ci.txt
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
# Disable clone protection for git lfs | ||
export GIT_CLONE_PROTECTION_ACTIVE=false | ||
|
||
sudo apt install git-lfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move LFS installation to a separate actions.yml
workflow, along with all other basic setup steps.
python src_python/habitat_sim/utils/datasets_download.py --uids ci_test_assets ycb rearrange_dataset_v2 --replace --data-path data/ --no-prune | ||
ls -la data/scene_datasets/habitat-test-scenes/ | ||
- name: Debugging with tmate | ||
uses: mxschmitt/action-tmate@v3.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really handy!
…ry removing some "fluff" from testing to see if necessary
Motivation and Context
Working branch to test migration to github actions. Do not merge.
How Has This Been Tested
WIP
Types of changes
Checklist