Fix _underscore access, rename Nethack variable as nethack.
#303
Conversation
facebook-github-bot
added
the
CLA Signed
| @@ -312,15 +310,15 @@ def __init__( | |||
| else: | |||
| ttyrec = None | |||
|
|
|||
| self.env = nethack.Nethack( | |||
| self.nethack = nethack.Nethack( | |||
There was a problem hiding this comment.
this is a much better renaming, though im sure will annoy downstream users.
There was a problem hiding this comment.
so funny how easy it is to ignore "call it what it is!"
There was a problem hiding this comment.
That's true re: downstream users. Hence I at least included @samvelyan here.
There was a problem hiding this comment.
We could include an alias.
Then again, this is easy to fix.
There was a problem hiding this comment.
Thanks for flagging this @heiner. I'll incorporate this into MiniHack after NLE's next release.
There was a problem hiding this comment.
Again, if it's easier we can add an alias.
There was a problem hiding this comment.
Hi team, do you know when there will be the next release of MiniHack? I'm trying to use recent nle because of issue fixed by #299
|
Seems like this PR brakes the |
Good catch, thanks! Fixed in #308 |
Fixes #273.
One reason this matters more than one would assume is that gym envs wrappers tend to forward non-underscore access but will typically fail with
._underscoreaccess. This happened e.g. for the 0.21 release which auto-wrapped every env.Also a bit more cleanup.