This repository has been archived by the owner on May 6, 2024. It is now read-only.
Add the filepath of the ttyrec if it exists to the xlogfile. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cdmatters
commented
May 12, 2022
win/rl/pynethack.cc
Outdated
| @@ -122,6 +122,10 @@ class Nethack | |||
| } | |||
| strncpy(settings_.scoreprefix, scoreprefix.c_str(), | |||
| scoreprefix.length()); | |||
| std::size_t found = ttyrec.rfind("/"); | |||
| if (found!=std::string::npos && found + 1 < ttyrec.length()) | |||
There was a problem hiding this comment.
why the found+1 check? found points to the "/", so in case someone names their ttyrec "/path/ttyrec.bz2/". Highly unlikely - maybe it would break? Will check.
This will make it easier for users to find which ttyrecs correspond to which metadata. Xlogfiles are only written to with natural endings; not guaranteed if you call "reset" before "done" is ready. This means if there is a panic and drop a game, you will not get alignment between your ttyrec reset number and xlogfile row. This adds an explicit link. NB: This only works because in nle (vs typical NetHack), we play the whole game in _one_ ttyrec.
cdmatters
force-pushed
the
eric/xlogfile-filelogging
branch
from
970beed
to
b9061b1
Compare
tscmoo
approved these changes
May 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier for users to find which ttyrecs correspond to
which metadata. Xlogfiles are only written to with natural endings; not
guaranteed if you call "reset" before "done" is ready. This means if
there is a panic and drop a game, you will not get alignment between
your ttyrec reset number and xlogfile row. This adds an explicit link.
NB: This only works because in nle (vs typical NetHack), we play the
whole game in one ttyrec.